Update contributing page
This commit is contained in:
@@ -6,7 +6,7 @@ Thanks for submitting or fixing an icon! Here is a helpful guide to what you nee
|
||||
Additionally, you can do these helpful things if you have time:
|
||||
- [ ] Edit Readme
|
||||
- [ ] Add reference image
|
||||
- [ ] Edit reference page
|
||||
- [ ] Add official brand guidelines URl
|
||||
- [ ] Android Image
|
||||
|
||||
## New File
|
||||
@@ -59,12 +59,10 @@ This will update the average file size at the top of the file as well as regener
|
||||
|
||||
* Find an *official* logo.
|
||||
* Add it to `/images/reference/`
|
||||
|
||||
## Reference Page
|
||||
|
||||
* Edit the file [`images/reference/index.md`](images/reference/index.md)
|
||||
* Add a link to the *official* style guide or brand guidelines.
|
||||
* For example `| <img src="/images/svg/nameofservice.svg" width="256" /> | <img src="/images/reference/nameofservice.jpg" width="256" /> | https://example.com/press |`
|
||||
* It must have the same filename as the image you added to `/images/svg/`
|
||||
* It's OK if it has a different extension. `nameofservice.png` is fine.
|
||||
* Add the brand guidelines URl in a new file within `/images/svg/`
|
||||
* For example, create a file called `/images/reference/nameofservice.url` with the contents `https://example.com/brand-guidelines`
|
||||
|
||||
## (Optional) Create Android Version
|
||||
|
||||
@@ -76,4 +74,4 @@ See: https://issuetracker.google.com/issues/176694227
|
||||
|
||||
Or, use https://inloop.github.io/svg2android/ to create an Android-compatible XML file.
|
||||
|
||||
Add the file to `/images/android-vector-drawable/`
|
||||
Add the file to `/images/android-vector-drawable/`
|
@@ -36,7 +36,7 @@ for ref_url in ref_list:
|
||||
readme_table = "<table>\n"
|
||||
check_table = '<table><tr><th>SVG Icon</th><th>Circle Icon</th><th>Reference</th><th>Source</th></tr>\n'
|
||||
reference_table = "-|-|-\n"
|
||||
missing_table = " | ** No Reference Image Found ** | \n"
|
||||
missing_table = "\n\n | ** No Reference Image Found ** | \n"
|
||||
|
||||
counter = 0
|
||||
for svg in svg_data:
|
||||
@@ -58,7 +58,7 @@ for svg in svg_data:
|
||||
|
||||
reference_table += '\n'
|
||||
else:
|
||||
missing_table += f'<img src="{img_domain}images/svg/{svg_file}" width="256" /> | {name} <br/>*[{svg}]* | \n'
|
||||
missing_table += f'<img src="{img_domain}images/svg/{svg_file}" width="256" /> | {name} <br/>*[{svg}.svg]* | \n'
|
||||
|
||||
check_table += '</tr>\n'
|
||||
|
||||
|
Reference in New Issue
Block a user